Refactor wet/dry logic into a new subclass of Effect

[ndonald2]

Serves two purposes:

• Effects that don't need wet/dry levels (filters for example) are always more efficient now
  • No need to set "isAlwaysWet", which was a bit awkward to do
• Effects without wet/dry levels shouldn't have setters to change wet/dry levels

[ndonald2]

@morganpackard If you're OK with some of these less-visible architectural changes, I'd like to start getting them merged into development more quickly. There are features in a few different branches that would be nice to use and build on at the same time.

Not talking about bug fixes, just smaller architectural changes - I'm trying to do better about keeping feature pull requests small/granular to make it clear what's been changed, rather than bunch them all into one massive pull request.

I know you probably don't have time to review all the code changes, but if it looks good at a high-level, I think it's probably OK to just get features merged into development and fix any bugs that come up as they come up.

Thanks!

[morganpackard]

The wet/dry thing makes sense. Go for it.

Sent from my iPhone

On Aug 2, 2013, at 10:59 AM, "Nick D." notifications@github.com wrote:

@morganpackard https://github.com/morganpackard If you're OK with some of these less-visible architectural changes, I'd like to start getting them merged into development more quickly. There are features in a few different branches that would be nice to use and build on at the same time.

Not talking about bug fixes, just smaller architectural changes - I'm trying to do better about keeping feature pull requests small/granular to make it clear what's been changed, rather than bunch them all into one massive pull request.

I know you probably don't have time to review all the code changes, but if it looks good at a high-level, I think it's probably OK to just get features merged into development and fix any bugs that come up as they come up.

Thanks!

— Reply to this email directly or view it on GitHubhttps://github.com/TonicAudio/Tonic/pull/204#issuecomment-22011255 .