search

TonicAudio / Tonic

Easy and efficient audio synthesis in C++
The Unlicense
524 stars 62 forks source link

Backticks in linux example makefile #267

Open son0p opened 8 years ago

son0p commented 8 years ago

To compile for UNIX_JACK I had to put backticks to part of line 52

https://github.com/TonicAudio/Tonic/blob/master/examples/Standalone/Linux/Makefile#L53

not working :

ifeq ($(AUDIO_API),UNIX_JACK)
RTAUDIO_LIBS = pkg-config --cflags --libs jack -lpthread

working 

ifeq ($(AUDIO_API),UNIX_JACK)
RTAUDIO_LIBS = `pkg-config --cflags --libs jack` -lpthread

thanks to @falktx

falkTX commented 8 years ago

you forgot that github uses those as special characters. the working version is this:

`pkg-config --cflags --libs jack` -lpthread
son0p commented 8 years ago

corrected, thanks

morganpackard commented 8 years ago

Thanks! I don't know a thing about makefiles. Can anyone else confirm that this is a change that should be added to the main repository? If so, I'll accept a PR for it.

On Fri, Oct 2, 2015 at 1:31 PM, federico lopez notifications@github.com wrote:

corrected, thanks

— Reply to this email directly or view it on GitHub https://github.com/TonicAudio/Tonic/issues/267#issuecomment-145093031.

Morgan Packard cell: (720) 891-0122 twitter: @morganpackard

falkTX commented 8 years ago

yes, that change is fine. without it you're adding "pkg-config..." directly as gcc arguments, which of course doesn't work.