TonimatasDEV / PacketFixer

A simple mod to solve various problems with packets.
MIT License
23 stars 2 forks source link

Possible solution for #21 #22

Closed Sunconure11 closed 12 months ago

Sunconure11 commented 1 year ago

https://github.com/TonimatasDEV/PacketFixer/issues/21#issuecomment-1716807706

You should probably check this out.

Sunconure11 commented 1 year ago

https://apexminecrafthosting.com/pricing/?game=minecraft

Using the EX Series plan.

Sunconure11 commented 1 year ago

My PC may be more powerful, but I'd rather wait until I have something like a 5950 for running any servers from my machine, so that I have more cores and threads free.

I am also using Aikar's flags on the server, to help with performance.

Sunconure11 commented 1 year ago

I might have found someone to help with clean up. If, after this effort, this still happens, I'll come here. I will hold onto a build of Packet Fix created here just until then, just in case any issues pop up in singleplayer while working on this

Sunconure11 commented 1 year ago

Also, this issue first came up while testing, but just to make sure of something, but is this my GPU going bad, or something else?

I am starting on some cleanup of the pack (mod count is deceptive, it is actually 648 as of typing this, but that is due to me cleaning stuff up) up until I can get it to a point where I can enter fully and load a world,

image

Sunconure11 commented 1 year ago

Hm... I have a suspect mod, but I don't know for certain. However, I am calling it suspect due to it's nature.

https://github.com/MehVahdJukaar/WoodGood

Sunconure11 commented 1 year ago

My reason for thinking it could be suspect is due to the sheer amount of recipes it could end up adding in the right situations.

I am going to turn it off, and see what happens.

Edit 1: Okay, so this wasn't the cause. Will look into further clean up later. Though speed was much greater.

Sunconure11 commented 1 year ago

@embeddedt

You wanna take this over? There is a lot of info here.

Also, would it be possible to make a version of the packet splitter mixin that is compatible with Krypton?

embeddedt commented 1 year ago

Not sure what I'm expected to see/do here.

Sunconure11 commented 1 year ago

https://github.com/MinecraftForge/MinecraftForge/pull/7485

https://github.com/FabricMC/fabric/pull/2525

There were two, separate ideas of the same thing, in these pulls. A packet splitter, basically. Forge has an implementation but Fabric/Quilt do not.

embeddedt commented 1 year ago

Doesn't Connectivity already solve this issue by bumping the maximum packet size?

Sunconure11 commented 1 year ago

I had also did quite a bit of testing to see if my issue was packet-related or mod-count related. Still working on trimming the mod count.

And it seems in some cases, it does not fully solve the issue, if this issue is packet-related.

TonimatasDEV commented 1 year ago

Doesn't Connectivity already solve this issue by bumping the maximum packet size?

Connectivity is really just a monitor, it only fixes 3 packet size (minecraft have 6), phantom blocks, improves errors and gives you information about packet usage. Connectivity does nothing else.

Sunconure11 commented 1 year ago

Doesn't Connectivity already solve this issue by bumping the maximum packet size?

Looks like according to @TonimatasDEV, it does not really. @embeddedt

TonimatasDEV commented 1 year ago

@Sunconure11 The version I passed you does not work?

Sunconure11 commented 1 year ago

@Sunconure11 The version I passed you does not work?

It works, but I was referring to Embed.

Sunconure11 commented 1 year ago

Well, I still can't load into a server fully, as it just stalls in a ghost world, best way to describe it, despite the console saying I'm in.

Sunconure11 commented 1 year ago

Singleplayer still runs fine.

Sunconure11 commented 1 year ago

While hunting for people to aid me with my pack, someone pointed out this issue to me, and given I have both mods… maybe there’s something here that can be done? https://github.com/terrarium-earth/Chipped/issues/214

Sunconure11 commented 1 year ago

Hm, are there any limits on the packet splitter? Just asking while I pursue a few possible leads.