search

Tonkpils / snag

Automatic build tool for all your projects
MIT License
32 stars 4 forks source link

Allow specifying commands as flags #44

Closed Tonkpils closed 8 years ago

Tonkpils commented 8 years ago

Let's discuss a couple of things on this PR.

Right now, it's either one or the other flags or snag file.

The issue comes when the snag file exists and flags are given. If command flags are specified the snag file won't be read. This can come off as a surprise to the user and we need to also think about adding ignores. What if the user has ignored files in the snag file but specifies commands as flags?

zabawaba99 commented 8 years ago

I'd take a naive approach to this issue. Ideally, we want to strive for a user to consume snag with a .snag.yaml. I see using the commands as a quick way to get some validation on some code or using it for some automated task.

I'd say if you specify the flags, you can not ignore any files in the directory and the .snag.yml will be ignored. We can document the exposed flags and put that in bold in the readme.

zabawaba99 commented 8 years ago

:shipit: