Closed Tonkpils closed 8 years ago
Different package management tools that support the vendor
directory https://github.com/golang/go/wiki/PackageManagementTools
@Tonkpils I created two PR that both use Godeps differently.
vendor/
directory../...
notation (ref)./...
when building, testing, linting.After looking at both PRs, my preference would be to go with #58 .
I'm actually for #57 the reasons are mostly looking forward:
Cons: Does not work unless you explicitly set an environment var We can't just use the ./... notation (ref) We can't build with go1.4 anymore
- The environment variable is actually going away and it will be the default for go 1.6
- There's a bit of a workaround using
go test $(go list ./... | grep -v /vendor/)
- Do we care to build with 1.4 anyway? This is only relevant in development and we're already in 1.5. I don't see us going back versions but rather forward.
I'm taking a look at both PRs now and I'll check back here with my update once I see the actual code.
I'm ok with going with #57.
go list
bit is a MUCH better way to list the packages :+1:.I preferred #58 more for personal reasons in having to manage the environment variable ;). I'll close that PR for now and continue to polish #57 .
Hopefully something that will allow using Go's vendoring but if there's other options then I'm open for it.