Reduce URL down to below recommended sizes

Tonomy-Foundation / Tonomy-ID-SDK

This Software Development Kit is used in Tonomy ID to interact and call with the Antelope blockchain and services. It is also used as the public API for integration by applications to do single sign-on, share credentials and sign transactions.

https://tonomy-id-sdk-tonomy-foundation.vercel.app

Apache License 2.0

5 stars 1 forks source link

Reduce URL down to below recommended sizes #316

Open theblockstalk opened 10 months ago

theblockstalk commented 10 months ago

When a URL with a wallet request, or wallet response is sent by the URL it can be very long. With 2x login request + 2x data sharing request the length was >9000 characters

Different servers and browsers support maximum limits:

https://vercel.com/docs/functions/edge-functions/limitations = ~14000 chars
https://stackoverflow.com/questions/417142/what-is-the-maximum-length-of-a-url-in-different-browsers = 8000 modern browsers, 2048 IE11 support

We need to reduce the length of our URL. We could do this in A few obvious ways to me at the moment ( there may be other ways):

Use did:key instead of did:jwk which has a massive number of less characters
limit the URL to only be used for the login request, and after that use the communication server to send any other requests to and from the wallet

theblockstalk commented 9 months ago

I have tested did:key with the Veramo SDK: https://github.com/theblockstalk/learning/tree/master/veramo

Results

using did:key

did.length = 56 (13%)
vc.length = 443

using did:jwk

did.length = 218 (33%)
vc.length = 661

Also noted that it looks like did:key with Secp256k1 key does not currently support the keyAgreement needed to support DIDComm. See here https://discord.com/channels/878293684620234752/890207307433136178/1172839857006055484

theblockstalk commented 9 months ago

currently blocked by this to implement did:key https://github.com/Tonomy-Foundation/Tonomy-ID/issues/758

so to achieve this task we might need to make some big multi-repo build changes :( in

did-antelope-resolve
SDK https://github.com/Tonomy-Foundation/Tonomy-ID/issues/758
SDK clients (ID, Communication and App) website polyfills

theblockstalk commented 9 months ago

currently blocked by this to implement did:key https://github.com/Tonomy-Foundation/Tonomy-ID/issues/758

so to achieve this task we might need to make some big multi-repo build changes to use the @veramo framework instead of directly with did-jwt :( in

did-antelope-resolve
SDK https://github.com/Tonomy-Foundation/Tonomy-ID/issues/758
SDK clients (ID, Communication and App) website polyfills

And then application changes

use @veramo for VC signin'
use @veramo did:key
use @veramo DIDComm to replace our URL and websocket messaging

theblockstalk commented 9 months ago

last sprint: 1 next sprint: 2

theblockstalk commented 1 month ago

Completed. See https://github.com/Tonomy-Foundation/Tonomy-ID-Integration/pull/193#issuecomment-2267712311