TonyGen / mongodb-erlang

Fork of MongoDB driver for Erlang. mongodb now holds the master repository for this driver.
65 stars 16 forks source link

Multiple fixes and additions. #16

Closed soplakanets closed 12 years ago

soplakanets commented 12 years ago

Major chanages:

superbobry commented 12 years ago

Makefile, why, really?

soplakanets commented 12 years ago

@superbobry I am not sure what you mean. If you're asking why make and not X - answer is simple, because everybody has it installed. I am not a fan of make neither, but, not sure introducing another build tool is a good idea.

Anyways, I am up for suggestions, have no strong feelings for make :) Let's let maintainer decide.

superbobry commented 12 years ago

Well, I'm not very familiar with Erlang environment, but it looks like most of the folks just use rebar for everything; this includes tests (which seem to be the only two long lines in the Makefile you've written).

soplakanets commented 12 years ago

@superbobry My opinion:

  1. As I said -- it's a matter of personal preference. I personally hate typing rebar get-deps compile if I can shorten it to make.
  2. Unfortunately tests in a current form can not be run with rebar. Check source code.
  3. Most of the projects I saw use rebar+Makefiles, including Webmachine, which is a product of a company behind rebar :)
TonyGen commented 12 years ago

Hi guys, this TonyGen site is no longer the master for mongodb-erlang, mongodb is. Can you please post there. Thanks, Tony

superbobry commented 12 years ago

Sure, but mongodb's repository has no issues enabled.

TonyGen commented 12 years ago

Mongo tracks issues at jira.mongodb.org. Select Erlang project.