TonyGermaneri / canvas-datagrid

Canvas based data grid web component. Capable of displaying millions of contiguous hierarchical rows and columns without paging or loading, on a single canvas element.
BSD 3-Clause "New" or "Revised" License
1.43k stars 184 forks source link

Delete cell content works even when editable is set to false #458

Open kemsky opened 2 years ago

kemsky commented 2 years ago

Expected behavior and actual behavior.

readonly grid, editable: false.

Steps to reproduce the problem.

select cell, press delete key, cell clears

This bug was introduced here: https://github.com/TonyGermaneri/canvas-datagrid/commit/439b3376f77b4d4c0ed4a7ffcc453c47deee9226

kemsky commented 1 month ago
            this.canvasDatagrid.addEventListener('keydown', (e) => {
                const event: KeyboardEvent = e.NativeEvent;
                if (getKeyCode(event) === 8 || getKeyCode(event) === 46) {
                    e.preventDefault();
                }
            });