TonyGermaneri / canvas-datagrid

Canvas based data grid web component. Capable of displaying millions of contiguous hierarchical rows and columns without paging or loading, on a single canvas element.
BSD 3-Clause "New" or "Revised" License
1.43k stars 184 forks source link

Remove unnecessary codes in the context file of Karma #481

Closed hangxingliu closed 2 years ago

hangxingliu commented 2 years ago

Hi @ndrsn, I have run tests in watch mode(npm run test:watch) with this patch under multiple OS (Ubuntu and OSX). And all of the results are passed.


I mark these codes as comments because these codes cause the async test to be failed in watch mode.
I guess these codes are duplicate with window.__karma__.loaded(). Then they make the async tests are run twice with the same Mocha instance.

window.onload = () => {
    mocha.run();
};
// Error:
// Mocha instance is currently running tests, cannot start a next test run until this one is done