fix sorting on header click

TonyGermaneri / canvas-datagrid

Canvas based data grid web component. Capable of displaying millions of contiguous hierarchical rows and columns without paging or loading, on a single canvas element.

BSD 3-Clause "New" or "Revised" License

1.42k stars 184 forks source link

fix sorting on header click #550

Closed romanstetsyk closed 1 year ago

romanstetsyk commented 1 year ago

Fixes #261.

Changes proposed in this pull request:

check the value of the allowSorting attribute before sorting.

ndrsn commented 1 year ago

Hey @romanstetsyk, thanks for this! This change causes a test to fail, but I'm not sure that test is correct to start with (I'm not the original author).

So I'm going to merge this soon, but I should tell you that we can't do a new release for this right away because there's another failing test caused by an earlier change which still is under investigation. I'll update this thread once I do a new release.

Thanks again :)

ndrsn commented 1 year ago

This change causes a test to fail

I believe the actual failure for the test was introduced in #515, so reverted that.