search

TonyLiu836 / GetFit

0 stars 0 forks source link

7.3 design program logic #16

Closed Junzhou-712 closed 7 months ago

Junzhou-712 commented 10 months ago

Implemented IExerciseEvent and some derived classes. @TonyLiu836 @RunpengNie @VincentXiao997 Could you help me to review this part. Thanks! And I am curious that whether the flexibility class and customized class need an unit or not.

RunpengNie commented 10 months ago

The first thing that needs attention to is that no branch will be merged with the main branch except for release. Besides, remember to add review requests on your PR page. I have changed the merging target branch and added all the other 3 reviewers.

RunpengNie commented 10 months ago

The other minor change: we should name the branch name 7-Design-Program-Logic-3. Make sure the only special character we have in branch names is -.

Tony's PR also had this problem. Remember to follow the branch naming convention next time.

Junzhou-712 commented 9 months ago

@RunpengNie @TonyLiu836 @VincentXiao997 Could you review this feature about those classes? Thanks!