search

TonyTromp / tidal-connect-docker

This is the dockerized version of Tidal Connect Raspberry binairies. Can be seemlessly used in HifiberryOS or any other RPi based operating system running Docker.
160 stars 28 forks source link

Running audiocontrol2 in foreground not needed #26

Closed fff0x closed 1 year ago

fff0x commented 1 year ago

It's not required to execute the docker cmd interactively this fixes the issue that the audiocontrol2 daemon must be run in foreground. I have updated the README accordingly and extended the install.sh to make the automatic installation easier.

Edit: I notice issues after rebooting the hifiberry. The AC2 service is now started after the tidal service, but I guess since the container it is not completely ready, it will break something in AC2. It's still necessary to "systemctl restart audiocontrol2" to make it work after the tidal container is fully ready. I was working with adding a sleep in ExecPre of the AC2 unit file, but this leads into unstable system (caused by the hifiberry watchdog service?). It seems someone has to put some more work into the TidalConnect AC2 module to make it work more stable.

Edit2: When it's required to restart the TidalConnect container an restart of the audiocontrol2 service is necessary too.

TonyTromp commented 1 year ago

Nice one! Thanks. Unfortunately i dont have a Tidal subscribtion and therefore my contributions has gone stale on this project. This change sure makes me want to invest more time on the project again. Thank you!