search

TonyValenti / Mime-Detective-clarkis117

Mime type detector for files, byte arrays, and streams, .NET Standard Fork
MIT License
38 stars 9 forks source link

"End of Central Directory record could not be found."- 0.0.6-beta1 #16

Closed 1100594 closed 6 years ago

1100594 commented 6 years ago

Hi @clarkis117,

I've updated the nuget to version 0.0.6-beta1 and now I'm getting the following error "End of Central Directory record could not be found" with a byte array of a Excel file.

Sample of code: File.ReadAllBytes(filePath).GetFileType()

Sample of file: test.xlsx

TargetFramework: .NET Core 2.0

Could you help me with this?

Additionally, do you have any expected date for the final nuget release of the 0.0.6?

Thank you,

clarkis117 commented 6 years ago

Thank you for the bug report, the issue was being caused by using the incorrect array length in the ZipFileAnalyzer class. ReadResult.ReadLength was being incorrectly used when creating a MemoryStream in the ZipFileAnalyzer class. I updated the documentation that it's intended to max out at 560, and that when Analyzers are referring to whole files passed as arrays they should use ReadResult.Array.Length instead of ReadResult.ReadLength.

I just merged the fix, and the new version (0.0.6-beta2) should be up on NuGet.

clarkis117 commented 6 years ago

@1100594 As for release plans, I still need to update many of the doc comments to reflect changes for 0.0.6, post benchmarks and usage guidelines for the new trie-based algs, update the markdown page for the GitHub repo, and review the test cases to ensure there are not anymore major gaps like this. I'm thinking maybe by next weekend.

1100594 commented 6 years ago

@clarkis117 thanks for the fix and information