search

Tonyyyy1234 / Dasmoto_Project

Mock-up of an arts and crafts store's homepage
0 stars 0 forks source link

Summary #3

Open farishkash opened 6 years ago

farishkash commented 6 years ago

Overall met expectations.

In this first project, I look at two primary items with the main goal being to stop inefficient or bad practices early.

First, did you use divs, ids/classes to manage and organize your HTML content? You use divs and some of the newer HTML 5 elements. Good job on this.

Second, is your CSS efficient and non-repetitive? You avoided the common mistakes that usually happens in this first project. My only issue with regards to CSS is that you used inline styling to apply width and height directly to the image. This can be considered an inefficient practice where if you had a site of a few 100 images you would have to change each width and height individual vs a class where you would change that information once.

To prepare you for the upcoming projects I like you to go to flexboxfroggy.com. See how far you can get, the later projects uses flexbox heavily and this will help you immensely.

Tonyyyy1234 commented 6 years ago

Thanks, Farish! I appreciate the feedback. Makes total sense about applying width and height using CSS.