search

TooAngel / screeps

TooAngel NPC / bot / source code for screeps
https://screeps.com
GNU Affero General Public License v3.0
591 stars 154 forks source link

Code quality #610

Open TooAngel opened 3 years ago

TooAngel commented 3 years ago

Working on it for some time, it still needs to be better. Code climate is a got point to have a look. Basically it is reducing complexity and length of functions and splitting up large files into smaller units.

iyosayi commented 3 years ago

Hello, @TooAngel could you please explain more? I would love to take this issue.

TooAngel commented 3 years ago

Not sure if you know screeps (https://screeps.com/). It is a massive multiple player strategy game with an in game editor. I released my code as bot (which everyone can use on their private servers) as well as a code base for others. A lot of code is written in the in game editor while playing the game, so written fast not optimized on quality.

I added codeclimate (https://codeclimate.com/) which showed that there is a lot of complexity. You can also run eslint -c .eslintrc-codeclimate src/. I think extracting certain functionality into other methods / splitting up files can solve a lot of issues.

I also think there is also room for improvement in javascript/nodejs knowledge, it was my first bigger project getting into javascript.

Does that help?