Closed TooAngel closed 3 years ago
This pull request will be automatically merged by worlddriven in 1 day(s) and 3 hour(s).
The start date is based on the latest Commit date / Pull Request created date / (force) Push date.
The time to merge is 5 days plus 5 days for each commit.
Check the worlddriven
status check or the dashboard for actual stats.
To speed up or delay the merge review the pull request:
The branch of this pull request was updated so the auto-merge time has been reset.
It will be automatically merged by worlddriven in 1 day(s) and 3 hour(s).
Check the worlddriven
status check or the dashboard for actual stats.
The branch of this pull request was updated so the auto-merge time has been reset.
It will be automatically merged by worlddriven in 1 day(s) and 3 hour(s).
Check the worlddriven
status check or the dashboard for actual stats.
The branch of this pull request was updated so the auto-merge time has been reset.
It will be automatically merged by worlddriven in 1 day(s) and 3 hour(s).
Check the worlddriven
status check or the dashboard for actual stats.
Thank you for the review. This pull request will be automatically merged by worlddriven in 0 day(s) and 20 hour(s). Current votes: 185/202.
Check the worlddriven
status checks or the dashboard for actual stats.
The branch of this pull request was updated so the auto-merge time has been reset.
It will be automatically merged by worlddriven in 0 day(s) and 20 hour(s).
Check the worlddriven
status check or the dashboard for actual stats.
Thank you for the review. This pull request will be automatically merged by worlddriven in 0 day(s) and 20 hour(s). Current votes: 185/202.
Check the worlddriven
status checks or the dashboard for actual stats.
How tied to adding this write-good are you @TooAngel ? I, more than most people, care about the proper use of language but failing CI tests due to using the passive voice or write-good mentioning that "easily can weaken meaning" seems more hassle than it is worth. I've approved the changes, as they seem fine to me, but thought I should raise the question.
How tied to adding this write-good are you @TooAngel ? I, more than most people, care about the proper use of language but failing CI tests due to using the passive voice or write-good mentioning that "easily can weaken meaning" seems more hassle than it is worth. I've approved the changes, as they seem fine to me, but thought I should raise the question.
I'm not super tied to write-good
, but I think having a spell checker or grammar checker helps to improve the quality of text, especially because it is not my native language. Also, I prefer that reviewers look into the Ideas behind the Pull Requests, instead of stupid spelling mistakes.
Maybe let's remove the annoying rules: https://www.npmjs.com/package/write-good#checks
So I'm fine with removing adverb
. Anything else where you think it is more annoying than improving the style?
The branch of this pull request was updated so the auto-merge time has been reset.
It will be automatically merged by worlddriven in 0 day(s) and 20 hour(s).
Check the worlddriven
status check or the dashboard for actual stats.
So I'm fine with removing
adverb
. Anything else where you think it is more annoying than improving the style?
All of the rules, even the "adverb" one, seem fine to me; it's just whether the failing test is worth the improvement and how accurately it detects the defects in the first place. If it isn't too much trouble (as I see you've disabled the adverb one now and changed the sentence back) could we run it with the defaults for a while and see how it goes? The changes were an improvement and a failing test isn't as big of an issue as the red 'X' makes it seem.
K, so I would keep it like this. We can enable the adverb at some point again.
I think in an environment where you don't have a single person watching over the quality it is essential to enforce some quality metrics. So having CI checks (also for language is IMHO important), which tools to use for that is a different question and we need to get more experience.
This pull request was merged by worlddriven.
Adapt CONTRIBUTING.md and README.md accordingly.