search

TooAngel / worlddriven

Automatic and well-defined pull request merged based on contribution-based weighted voting
GNU Affero General Public License v3.0
17 stars 14 forks source link

Add fade in effect to the latter two phases #213

Closed IanFindlay closed 3 years ago

IanFindlay commented 3 years ago

Not sure if this is quite what you had in mind @TooAngel but I think it's at least close. Added a blurred effect to the latter two phases with a button to 'reveal' them and an explanatory paragraph.

worlddrivenbot commented 3 years ago

This pull request will be automatically merged by worlddriven in 9 day(s) and 16 hour(s). The start date is based on the latest Commit date / Pull Request created date / (force) Push date. The time to merge is 5 days plus 5 days for each commit. Check the worlddriven status check or the dashboard for actual stats.

To speed up or delay the merge review the pull request:

  1. Files changed
  2. Review changes
TooAngel commented 3 years ago

I'm not so sure.

I thought about a gradient slowly graying out the text from top to bottom, so that you can read the first lines and increasing the transparency.

Hm, I don't think the Reveal is a good idea. It is like these paywalls and we are not like that. I do like the explanatory paragraph.

IanFindlay commented 3 years ago

Yeah I wasn't sold on it myself. With the transparency idea, how would the rest of the text become readable? Or would it be just be noticeably paler but still readable even at the bottom? Drafted this PR for now.

TooAngel commented 3 years ago

Alternatively, we could replace the button which an on scroll effect. So while scrolling down the text gets unblurred. This could give less a feeling of a paywall, and still somehow indicating that the future is blurry.

Btw. I got offline feedback for the world driven project:

TooAngel commented 3 years ago

Yeah I wasn't sold on it myself. With the transparency idea, how would the rest of the text become readable? Or would it be just be noticeably paler but still readable even at the bottom? Drafted this PR for now.

Yeah, I thought, that it is still somehow readable, maybe even an easter-egg in the part which is not readable. Something like: "If you read that far you seem interested, how about heading over to the repository' or 'If you read that far, you get a beer, open an issue here'

We could also apply the scrolling idea here. If you scroll further it gets less transparent.

IanFindlay commented 3 years ago

Alternatively, we could replace the button which an on scroll effect. So while scrolling down the text gets unblurred. This could give less a feeling of a paywall, and still somehow indicating that the future is blurry.

Yeah, I might play around with this idea and see if I can get something I like. I wasn't a fan of the button (though I didn't really have the paywall association until you mentioned it) so a scroll-based effect seems good.

  • Logo is ~shitty~ not optimal

Agreed. I quite like the colour scheme chosen but that's about it.

  • Text too long, TL;DR appreciated

I can see the value of a TLDR at the top of the page. I don't consider 1200 words too long myself, but I know others might.

  • Maybe more pictures to make it better readable and understandable

Not sure what pictures we could include really? Could show the World Driven messages I suppose but I don't think that adds much to it. I think the TLDR at the top and perhaps a re-write that trims some of the fat might be sufficient.

TooAngel commented 3 years ago

I think a TLDR could make sense, I'm not sure how to formulate the idea in 1-2 sentences.

Maybe we could split parts up on to different pages (home, how it works, ...). IMHO the last weeks improved a lot, so I think it will take some time for me before I don't like the current anymore and I'm motivated to improve further :-) Also, the feedback is from a single person, so good to know, but not necessarily a task that needs to be addressed right now.

worlddrivenbot commented 3 years ago

The branch of this pull request was updated so the auto-merge time has been reset.

It will be automatically merged by worlddriven in 9 day(s) and 16 hour(s). Check the worlddriven status check or the dashboard for actual stats.

IanFindlay commented 3 years ago

See what you think of this. It's more subtle but I think it certainly works better than the blur and button.

worlddrivenbot commented 3 years ago

Thank you for the review. This pull request will be automatically merged by worlddriven in 18 day(s) and 11 hour(s). Current votes: -175/204.

Check the worlddriven status checks or the dashboard for actual stats.

worlddrivenbot commented 3 years ago

The branch of this pull request was updated so the auto-merge time has been reset.

It will be automatically merged by worlddriven in 18 day(s) and 14 hour(s). Check the worlddriven status check or the dashboard for actual stats.

IanFindlay commented 3 years ago

I think this should work. The implementation is actually better than my initial attempt as it should work (to some degree) on all screen sizes whereas the last one didn't work on small screens. Let me know if you think any tweaks are needed.

worlddrivenbot commented 3 years ago

Thank you for the review. This pull request will be automatically merged by worlddriven in 0 day(s) and 16 hour(s). Current votes: 189/206.

Check the worlddriven status checks or the dashboard for actual stats.

TooAngel commented 3 years ago

This pull request was merged by worlddriven.