TooTallNate / Java-WebSocket

A barebones WebSocket client and server implementation written in 100% Java.
http://tootallnate.github.io/Java-WebSocket
MIT License
10.53k stars 2.58k forks source link

Slf4j Dependency Declaration #1304

Closed vilorel closed 1 year ago

vilorel commented 1 year ago

Describe the bug The declaration of slf4j as a dependency creates issues with our slf4j version. I think modules should not dictate (logging) dependencies' versions. Check the excerpt and the link from the slf4j site below.

To Reproduce Steps to reproduce the behavior:

  1. .
  2. ..
  3. ...
  4. ....

Example application to reproduce the issue Any project that has the latest version of the slf4j.

Expected behavior Per the documentation on the slf4j site: Note that embedded components such as libraries or frameworks should not declare a dependency on any SLF4J binding but only depend on slf4j-api. When a library declares a compile-time dependency on a SLF4J binding, it imposes that binding on the end-user, thus negating SLF4J's purpose.

Debug log The the debug log (set the log level to TRACE) to help explain your problem.

Environment(please complete the following information):

Additional context Add any other context about the problem here.

PhilipRoman commented 1 year ago

This library only depends on slf4j-api as recommended by the documentation. The slf4j-simple dependency is used for testing, just like junit, etc: image Is the problem that you're using a different version of slf4j-api?

PhilipRoman commented 1 year ago

No activity and no real issue identified - closing