TooTallNate / Java-WebSocket

A barebones WebSocket client and server implementation written in 100% Java.
http://tootallnate.github.io/Java-WebSocket
MIT License
10.53k stars 2.58k forks source link

Protected methods to customize client thread names. #1422

Open NathanSweet opened 5 months ago

NathanSweet commented 5 months ago

Description

New protected methods allow the default thread names to be customized.

Related Issue

1421

Motivation and Context

This is useful in projects that have many threads and like to stay organized.

It is also useful when using multiple clients. Each client can name its threads differently. Without this, the threads can't be differentiated by name.

An alternative solution could be a prefix that is used for thread names, with suffixes like:

threadPrefix + "-read-" + id
threadPrefix + "-write-" + id
threadPrefix + "-checkConnection" (or "-connectionMonitor"?)

LMK if you would prefer that and I'll update the PR.

Server thread names are not considered in this PR.

How Has This Been Tested?

It's very simple, running the client tests all changes.

Types of changes

Checklist: