Use of the built-in url module for parsing the url.

TooTallNate / file-uri-to-path

Convert a `file:` URI to a file path

MIT License

27 stars 8 forks source link

Closed jdalton closed 7 years ago

jdalton commented 7 years ago

Hi @TooTallNate!

I'm evaluating this package and thought that it might benefit from using the built-in url package from Node. Would you be up for a PR?

TooTallNate commented 7 years ago

I'm trying to figure out what would be the benefit exactly. Better compatibility, simpler code or what?

jdalton commented 7 years ago

Simpler code. Relying on something that's built-in (hammered on a bit more).

TooTallNate commented 7 years ago

It's been so long since I wrote this module, I'm trying to remember why I wouldn't have used url module in the first place 🤔

I'd entertain a pull request!

jdalton commented 7 years ago

Moved to #3.