search

TooTallNate / node-bindings

Helper module for loading your native module's `.node` file
MIT License
411 stars 94 forks source link

Handle filenames with 'file://' shema, in getFileName method #40

Closed mathiasjakobsen closed 5 years ago

mathiasjakobsen commented 6 years ago

Will fix bindings for use with Electron.

Fixes https://github.com/TooTallNate/node-bindings/issues/29

E3V3A commented 6 years ago

@TooTallNate Please merge!

cinan commented 6 years ago

+1

ViliusSutkus89 commented 5 years ago

@mathiasjakobsen Thanks for the patch, solved one of my problems. However I ran into another one. fileName being file schema encoded means all the special characters are encoded too. Including spaces. C:/Program%20Files/ Ended up using "file-uri-to-path" module https://github.com/ViliusSutkus/node-bindings/commit/3953f2af8f3be00c46de8020340de27cd45045c4

TooTallNate commented 5 years ago

Thanks @mathiasjakobsen and @ViliusSutkus, I've merged your changes in d0bd6f89f993c81ca46dddf9de0683b4c396533c.