search

TooTallNate / node-lame

Node.js native bindings to libmp3lame & libmpg123
MIT License
567 stars 113 forks source link

add support for node 0.11.13 #34

Closed yhbyun closed 10 years ago

yhbyun commented 10 years ago

I patched your code to support node 0.11.13 using nan. This code also works on node 0.10.xx and I tested with your test code.

Some tests does not pass in node 0.11.13, so I modified the test code. But I don't know why failed.

Please, consider my patch..

stephen commented 10 years ago

@TooTallNate - would you mind taking a look at getting this merged?

TooTallNate commented 10 years ago

Thanks! Sorry for the delay on merging.

stephen commented 10 years ago

Amazing. Thanks!

stephen commented 10 years ago

(@TooTallNate - would you mind also cutting a release for this?)

TooTallNate commented 9 years ago

v1.1.2 is published (again, sorry for the delay on that)