search

TooTallNate / node-lame

Node.js native bindings to libmp3lame & libmpg123
MIT License
567 stars 113 forks source link

Add output format options to the mpg123 decoder #83

Closed mdluo closed 6 years ago

mdluo commented 6 years ago

Relevant issue: https://github.com/TooTallNate/node-lame/issues/52

First call mpg123_format_none to clear the output format table, then call mpg123_format to set the output format based on the option parameter of the Decoder constructor.

Encoding table: https://github.com/TooTallNate/node-lame/blob/master/deps/mpg123/src/libmpg123/mpg123.h.in#L348-L388

mpg123_format_none: https://www.mpg123.de/api/group__mpg123__output.shtml#ga931ca238347de394901c3baa13e7a8f8

mpg123_format: https://www.mpg123.de/api/group__mpg123__output.shtml#gadad5794afc300a997e517dbe397dc2c7

Inspired by: https://sourceforge.net/p/mpg123/mailman/message/25123550/

LinusU commented 6 years ago

Ehhh 🤔 does the last commit remove the entire library?

mdluo commented 6 years ago

@LinusU Just forgot this PR is still open 😂. I will submit another PR later, closing this one now.

mdluo commented 6 years ago

See: https://github.com/TooTallNate/node-lame/pull/86