search

TooTallNate / node-lame

Node.js native bindings to libmp3lame & libmpg123
MIT License
567 stars 113 forks source link

Replaced deprecated Nan and node functions to fix compilation in node 12 #97

Open suldashi opened 4 years ago

suldashi commented 4 years ago

I went through all the old Nan calls and replaced them with the new compatible ones. This fixes compilation in Node 12. All warnings have been fixed as well, so we can expect compatibility with future node versions well into the future.

amzn-chris-subagio commented 4 years ago

Oooh, I had just finished doing the same thing! Good to see more people want this : ) Looks like the build is just failing on the older version of node. Could you maybe edit the .travis.yml file as well to update the list to the expected version of node that Nan will support with the current interface?

Thanks!