Replaced deprecated Nan and node functions to fix compilation in node 12 - fixed

TooTallNate / node-lame

Node.js native bindings to libmp3lame & libmpg123

MIT License

567 stars 113 forks source link

Open tomscytale opened 4 years ago

tomscytale commented 4 years ago

clone of #97 but updates .travis.yml to remove older versions of node which break with this change

dy commented 4 years ago

Is that possible to proceed with any of the PRs please? @TooTallNate

schneefux commented 4 years ago

I've published this with prebuilt binaries (similar to #85) to my github packages: https://github.com/schneefux/node-lame

tomscytale commented 3 years ago

@TooTallNate - it would be great if you could merge and release this - as it stands node-lame is unable to work with the last 2 lts versions of node.

richiedevs commented 3 years ago

yeah