TooTallNate / node-ogg

Node.js native binding to libogg
MIT License
65 stars 36 forks source link

Build errors on latest xcode-install for macOS #22

Open MasterOdin opened 5 years ago

MasterOdin commented 5 years ago

Using Node 10 or 12, I get the following warnings/errors when attempting to install on macOS Mojave using latest xcode-select install.

> ogg@1.2.6 install /Users/mpeveler/Work/CISL/CAIS/speaker-worker/node_modules/ogg
> node-gyp rebuild

  CC(target) Release/obj.target/libogg/deps/libogg/src/framing.o
  CC(target) Release/obj.target/libogg/deps/libogg/src/bitwise.o
  LIBTOOL-STATIC Release/ogg.a
  CXX(target) Release/obj.target/ogg/src/binding.o
../src/binding.cc:62:15: warning: 'Call' is deprecated [-Wdeprecated-declarations]
    callback->Call(1, argv);
              ^
../../nan/nan.h:1739:3: note: 'Call' has been explicitly marked deprecated here
  NAN_DEPRECATED inline v8::Local<v8::Value>
  ^
../../nan/nan.h:104:40: note: expanded from macro 'NAN_DEPRECATED'
# define NAN_DEPRECATED __attribute__((deprecated))
                                       ^
../src/binding.cc:76:54: error: too few arguments to function call, single argument 'context' was not specified
  long size = static_cast<long>(info[2]->NumberValue());
                                ~~~~~~~~~~~~~~~~~~~~ ^
/Users/mpeveler/.node-gyp/12.9.1/include/node/v8.h:2577:3: note: 'NumberValue' declared here
  V8_WARN_UNUSED_RESULT Maybe<double> NumberValue(Local<Context> context) const;
  ^
/Users/mpeveler/.node-gyp/12.9.1/include/node/v8config.h:351:31: note: expanded from macro 'V8_WARN_UNUSED_RESULT'
#define V8_WARN_UNUSED_RESULT __attribute__((warn_unused_result))
                              ^
../src/binding.cc:105:15: warning: 'Call' is deprecated [-Wdeprecated-declarations]
    callback->Call(3, argv);
              ^
../../nan/nan.h:1739:3: note: 'Call' has been explicitly marked deprecated here
  NAN_DEPRECATED inline v8::Local<v8::Value>
  ^
../../nan/nan.h:104:40: note: expanded from macro 'NAN_DEPRECATED'
# define NAN_DEPRECATED __attribute__((deprecated))
                                       ^
../src/binding.cc:128:57: error: too few arguments to function call, single argument 'context' was not specified
  int serialno = static_cast<int>(info[1]->IntegerValue());
                                  ~~~~~~~~~~~~~~~~~~~~~ ^
/Users/mpeveler/.node-gyp/12.9.1/include/node/v8.h:2578:3: note: 'IntegerValue' declared here
  V8_WARN_UNUSED_RESULT Maybe<int64_t> IntegerValue(
  ^
/Users/mpeveler/.node-gyp/12.9.1/include/node/v8config.h:351:31: note: expanded from macro 'V8_WARN_UNUSED_RESULT'
#define V8_WARN_UNUSED_RESULT __attribute__((warn_unused_result))
                              ^
../src/binding.cc:146:15: warning: 'Call' is deprecated [-Wdeprecated-declarations]
    callback->Call(1, argv);
              ^
../../nan/nan.h:1739:3: note: 'Call' has been explicitly marked deprecated here
  NAN_DEPRECATED inline v8::Local<v8::Value>
  ^
../../nan/nan.h:104:40: note: expanded from macro 'NAN_DEPRECATED'
# define NAN_DEPRECATED __attribute__((deprecated))
                                       ^
../src/binding.cc:193:15: warning: 'Call' is deprecated [-Wdeprecated-declarations]
    callback->Call(6, argv);
              ^
../../nan/nan.h:1739:3: note: 'Call' has been explicitly marked deprecated here
  NAN_DEPRECATED inline v8::Local<v8::Value>
  ^
../../nan/nan.h:104:40: note: expanded from macro 'NAN_DEPRECATED'
# define NAN_DEPRECATED __attribute__((deprecated))
                                       ^
../src/binding.cc:226:15: warning: 'Call' is deprecated [-Wdeprecated-declarations]
    callback->Call(1, argv);
              ^
../../nan/nan.h:1739:3: note: 'Call' has been explicitly marked deprecated here
  NAN_DEPRECATED inline v8::Local<v8::Value>
  ^
../../nan/nan.h:104:40: note: expanded from macro 'NAN_DEPRECATED'
# define NAN_DEPRECATED __attribute__((deprecated))
                                       ^
../src/binding.cc:267:15: warning: 'Call' is deprecated [-Wdeprecated-declarations]
    callback->Call(4, argv);
              ^
../../nan/nan.h:1739:3: note: 'Call' has been explicitly marked deprecated here
  NAN_DEPRECATED inline v8::Local<v8::Value>
  ^
../../nan/nan.h:104:40: note: expanded from macro 'NAN_DEPRECATED'
# define NAN_DEPRECATED __attribute__((deprecated))
                                       ^
../src/binding.cc:407:3: warning: 'ForceSet' is deprecated [-Wdeprecated-declarations]
  SIZEOF(ogg_sync_state);
  ^
../src/binding.cc:404:8: note: expanded from macro 'SIZEOF'
  Nan::ForceSet(target, Nan::New<String>("sizeof_" #value).ToLocalChecked(), \
       ^
../../nan/nan_maybe_43_inl.h:117:1: note: 'ForceSet' has been explicitly marked deprecated here
NAN_DEPRECATED inline Maybe<bool> ForceSet(
^
../../nan/nan.h:104:40: note: expanded from macro 'NAN_DEPRECATED'
# define NAN_DEPRECATED __attribute__((deprecated))
                                       ^
../src/binding.cc:408:3: warning: 'ForceSet' is deprecated [-Wdeprecated-declarations]
  SIZEOF(ogg_stream_state);
  ^
../src/binding.cc:404:8: note: expanded from macro 'SIZEOF'
  Nan::ForceSet(target, Nan::New<String>("sizeof_" #value).ToLocalChecked(), \
       ^
../../nan/nan_maybe_43_inl.h:117:1: note: 'ForceSet' has been explicitly marked deprecated here
NAN_DEPRECATED inline Maybe<bool> ForceSet(
^
../../nan/nan.h:104:40: note: expanded from macro 'NAN_DEPRECATED'
# define NAN_DEPRECATED __attribute__((deprecated))
                                       ^
../src/binding.cc:409:3: warning: 'ForceSet' is deprecated [-Wdeprecated-declarations]
  SIZEOF(ogg_page);
  ^
../src/binding.cc:404:8: note: expanded from macro 'SIZEOF'
  Nan::ForceSet(target, Nan::New<String>("sizeof_" #value).ToLocalChecked(), \
       ^
../../nan/nan_maybe_43_inl.h:117:1: note: 'ForceSet' has been explicitly marked deprecated here
NAN_DEPRECATED inline Maybe<bool> ForceSet(
^
../../nan/nan.h:104:40: note: expanded from macro 'NAN_DEPRECATED'
# define NAN_DEPRECATED __attribute__((deprecated))
                                       ^
../src/binding.cc:410:3: warning: 'ForceSet' is deprecated [-Wdeprecated-declarations]
  SIZEOF(ogg_packet);
  ^
../src/binding.cc:404:8: note: expanded from macro 'SIZEOF'
  Nan::ForceSet(target, Nan::New<String>("sizeof_" #value).ToLocalChecked(), \
       ^
../../nan/nan_maybe_43_inl.h:117:1: note: 'ForceSet' has been explicitly marked deprecated here
NAN_DEPRECATED inline Maybe<bool> ForceSet(
^
../../nan/nan.h:104:40: note: expanded from macro 'NAN_DEPRECATED'
# define NAN_DEPRECATED __attribute__((deprecated))
                                       ^
../src/binding.cc:434:77: error: too few arguments to function call, single argument 'context' was not specified
    Nan::New<FunctionTemplate>(node_ogg_packet_replace_buffer)->GetFunction());
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
/Users/mpeveler/.node-gyp/12.9.1/include/node/v8.h:5961:3: note: 'GetFunction' declared here
  V8_WARN_UNUSED_RESULT MaybeLocal<Function> GetFunction(
  ^
/Users/mpeveler/.node-gyp/12.9.1/include/node/v8config.h:351:31: note: expanded from macro 'V8_WARN_UNUSED_RESULT'
#define V8_WARN_UNUSED_RESULT __attribute__((warn_unused_result))
                              ^
10 warnings and 3 errors generated.
make: *** [Release/obj.target/ogg/src/binding.o] Error 1
gyp ERR! build error
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/usr/local/Cellar/node@10/10.16.3/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:262:23)
gyp ERR! stack     at ChildProcess.emit (events.js:209:13)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:272:12)
gyp ERR! System Darwin 18.7.0
gyp ERR! command "/usr/local/Cellar/node/12.9.1/bin/node" "/usr/local/Cellar/node@10/10.16.3/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /Users/mpeveler/Work/CISL/CAIS/speaker-worker/node_modules/ogg
gyp ERR! node -v v12.9.1
gyp ERR! node-gyp -v v3.8.0
gyp ERR! not ok
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! ogg@1.2.6 install: `node-gyp rebuild`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the ogg@1.2.6 install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/mpeveler/.npm/_logs/2019-09-15T17_44_23_533Z-debug.log

My GCC/Clang version:

$ clang --version
Apple LLVM version 10.0.1 (clang-1001.0.46.4)
Target: x86_64-apple-darwin18.7.0
Thread model: posix
InstalledDir: /Library/Developer/CommandLineTools/usr/bin

Let me know if you would like further debug information.