TooTallNate / node-ogg

Node.js native binding to libogg
MIT License
65 stars 36 forks source link

Updated binding.cc to use new signatures in some functions #25

Open suldashi opened 4 years ago

suldashi commented 4 years ago

This fixes the build issues in Node 12, but the "ogg-packet" dependency needs to be fixed as well. "ogg-packet" depends on "ref-struct", which also needs to be fixed. That in turn depends upon "ref", also needs a fix. Finally, "ref" depends on "weak", which also needs to be fixed.

If you include this MR and the fixed I listed above, the entire range of packages that build upon node-ogg and node-opus will work again.

https://github.com/lxe/ref-struct/tree/node-12 https://github.com/lxe/ref/tree/node-12 https://github.com/lxe/node-weak/tree/node-12