TooTallNate / node-ogg

Node.js native binding to libogg
MIT License
65 stars 36 forks source link

Why Is the packet size capped at 48? and how to workaround #29

Closed Phil-Barber closed 3 years ago

Phil-Barber commented 4 years ago

I have opus buffers of length >48 that I want to encapsulate with ogg

Can you explain why the packet size is capped at 48? https://github.com/TooTallNate/node-ogg/blob/master/lib/packet.js#L27

I can't see any such restriction in the RFC under 6. Packet Size Limits (but I could just be misinterpreting it) https://tools.ietf.org/html/rfc7845#page-26

Given my situation, what's the easiest way to chunk my buffer? It only contains one frame, so my understanding is that I can't just split that into smaller chunks as necessary, while copying over the TOC byte from the original frame as per 3.2.2 https://tools.ietf.org/html/rfc6716#section-2.1.4

Phil-Barber commented 3 years ago

Pretty sure I was just getting the wrong end of the stick here