TooTallNate / node-ogg

Node.js native binding to libogg
MIT License
65 stars 36 forks source link

Install fails on node v16.13.0 #30

Open sz55net opened 2 years ago

sz55net commented 2 years ago

Hello! The build / install seems to fail on this version (haven't tested any others):

yarn add v1.22.17
[1/4] Resolving packages...
[2/4] Fetching packages...
[3/4] Linking dependencies...
[4/4] Building fresh packages...
error /home/george/js/vocall/node_modules/ogg: Command failed.
Exit code: 1
Command: node-gyp rebuild
Arguments: 
Directory: /home/george/js/vocall/node_modules/ogg
Output:
gyp info it worked if it ends with ok
gyp info using node-gyp@8.2.0
gyp info using node@16.13.0 | linux | x64
gyp info find Python using Python version 3.8.10 found at "/usr/bin/python3"
gyp info spawn /usr/bin/python3
gyp info spawn args [
gyp info spawn args   '/home/george/.nvm/versions/node/v16.13.0/lib/node_modules/npm/node_modules/node-gyp/gyp/gyp_main.py',
gyp info spawn args   'binding.gyp',
gyp info spawn args   '-f',
gyp info spawn args   'make',
gyp info spawn args   '-I',
gyp info spawn args   '/home/george/js/vocall/node_modules/ogg/build/config.gypi',
gyp info spawn args   '-I',
gyp info spawn args   '/home/george/.nvm/versions/node/v16.13.0/lib/node_modules/npm/node_modules/node-gyp/addon.gypi',
gyp info spawn args   '-I',
gyp info spawn args   '/home/george/.cache/node-gyp/16.13.0/include/node/common.gypi',
gyp info spawn args   '-Dlibrary=shared_library',
gyp info spawn args   '-Dvisibility=default',
gyp info spawn args   '-Dnode_root_dir=/home/george/.cache/node-gyp/16.13.0',
gyp info spawn args   '-Dnode_gyp_dir=/home/george/.nvm/versions/node/v16.13.0/lib/node_modules/npm/node_modules/node-gyp',
gyp info spawn args   '-Dnode_lib_file=/home/george/.cache/node-gyp/16.13.0/<(target_arch)/node.lib',
gyp info spawn args   '-Dmodule_root_dir=/home/george/js/vocall/node_modules/ogg',
gyp info spawn args   '-Dnode_engine=v8',
gyp info spawn args   '--depth=.',
gyp info spawn args   '--no-parallel',
gyp info spawn args   '--generator-output',
gyp info spawn args   'build',
gyp info spawn args   '-Goutput_dir=.'
gyp info spawn args ]
gyp info spawn make
gyp info spawn args [ 'BUILDTYPE=Release', '-C', 'build' ]
make: Entering directory '/home/george/js/vocall/node_modules/ogg/build'
  CC(target) Release/obj.target/libogg/deps/libogg/src/framing.o
  CC(target) Release/obj.target/libogg/deps/libogg/src/bitwise.o
  AR(target) Release/obj.target/deps/libogg/ogg.a
  COPY Release/ogg.a
  CXX(target) Release/obj.target/ogg/src/binding.o
../src/binding.cc: In member function ‘virtual void nodeogg::OggSyncWriteWorker::HandleOKCallback()’:
../src/binding.cc:62:27: warning: ‘v8::Local<v8::Value> Nan::Callback::Call(int, v8::Local<v8::Value>*) const’ is deprecated [-Wdeprecated-declarations]
   62 |     callback->Call(1, argv);
      |                           ^
In file included from ../src/binding.cc:23:
../../nan/nan.h:1744:3: note: declared here
 1744 |   Call(int argc, v8::Local<v8::Value> argv[]) const {
      |   ^~~~
../src/binding.cc: In function ‘Nan::NAN_METHOD_RETURN_TYPE nodeogg::node_ogg_sync_write(Nan::NAN_METHOD_ARGS_TYPE)’:
../src/binding.cc:76:54: error: no matching function for call to ‘v8::Value::NumberValue()’
   76 |   long size = static_cast<long>(info[2]->NumberValue());
      |                                                      ^
In file included from /home/george/.cache/node-gyp/16.13.0/include/node/node.h:63,
                 from ../src/binding.cc:22:
/home/george/.cache/node-gyp/16.13.0/include/node/v8.h:3099:39: note: candidate: ‘v8::Maybe<double> v8::Value::NumberValue(v8::Local<v8::Context>) const’
 3099 |   V8_WARN_UNUSED_RESULT Maybe<double> NumberValue(Local<Context> context) const;
      |                                       ^~~~~~~~~~~
/home/george/.cache/node-gyp/16.13.0/include/node/v8.h:3099:39: note:   candidate expects 1 argument, 0 provided
../src/binding.cc: In member function ‘virtual void nodeogg::OggSyncPageoutWorker::HandleOKCallback()’:
../src/binding.cc:105:27: warning: ‘v8::Local<v8::Value> Nan::Callback::Call(int, v8::Local<v8::Value>*) const’ is deprecated [-Wdeprecated-declarations]
  105 |     callback->Call(3, argv);
      |                           ^
In file included from ../src/binding.cc:23:
../../nan/nan.h:1744:3: note: declared here
 1744 |   Call(int argc, v8::Local<v8::Value> argv[]) const {
      |   ^~~~
../src/binding.cc: In function ‘Nan::NAN_METHOD_RETURN_TYPE nodeogg::node_ogg_stream_init(Nan::NAN_METHOD_ARGS_TYPE)’:
../src/binding.cc:128:57: error: no matching function for call to ‘v8::Value::IntegerValue()’
  128 |   int serialno = static_cast<int>(info[1]->IntegerValue());
      |                                                         ^
In file included from /home/george/.cache/node-gyp/16.13.0/include/node/node.h:63,
                 from ../src/binding.cc:22:
/home/george/.cache/node-gyp/16.13.0/include/node/v8.h:3101:40: note: candidate: ‘v8::Maybe<long int> v8::Value::IntegerValue(v8::Local<v8::Context>) const’
 3101 |   V8_WARN_UNUSED_RESULT Maybe<int64_t> IntegerValue(
      |                                        ^~~~~~~~~~~~
/home/george/.cache/node-gyp/16.13.0/include/node/v8.h:3101:40: note:   candidate expects 1 argument, 0 provided
../src/binding.cc: In member function ‘virtual void nodeogg::OggStreamPageinWorker::HandleOKCallback()’:
../src/binding.cc:146:27: warning: ‘v8::Local<v8::Value> Nan::Callback::Call(int, v8::Local<v8::Value>*) const’ is deprecated [-Wdeprecated-declarations]
  146 |     callback->Call(1, argv);
      |                           ^
In file included from ../src/binding.cc:23:
../../nan/nan.h:1744:3: note: declared here
 1744 |   Call(int argc, v8::Local<v8::Value> argv[]) const {
      |   ^~~~
../src/binding.cc: In member function ‘virtual void nodeogg::OggStreamPacketoutWorker::HandleOKCallback()’:
../src/binding.cc:193:27: warning: ‘v8::Local<v8::Value> Nan::Callback::Call(int, v8::Local<v8::Value>*) const’ is deprecated [-Wdeprecated-declarations]
  193 |     callback->Call(6, argv);
      |                           ^
In file included from ../src/binding.cc:23:
../../nan/nan.h:1744:3: note: declared here
 1744 |   Call(int argc, v8::Local<v8::Value> argv[]) const {
      |   ^~~~
../src/binding.cc: In member function ‘virtual void nodeogg::OggStreamPacketinWorker::HandleOKCallback()’:
../src/binding.cc:226:27: warning: ‘v8::Local<v8::Value> Nan::Callback::Call(int, v8::Local<v8::Value>*) const’ is deprecated [-Wdeprecated-declarations]
  226 |     callback->Call(1, argv);
      |                           ^
In file included from ../src/binding.cc:23:
../../nan/nan.h:1744:3: note: declared here
 1744 |   Call(int argc, v8::Local<v8::Value> argv[]) const {
      |   ^~~~
../src/binding.cc: In member function ‘virtual void nodeogg::StreamWorker::HandleOKCallback()’:
../src/binding.cc:267:27: warning: ‘v8::Local<v8::Value> Nan::Callback::Call(int, v8::Local<v8::Value>*) const’ is deprecated [-Wdeprecated-declarations]
  267 |     callback->Call(4, argv);
      |                           ^
In file included from ../src/binding.cc:23:
../../nan/nan.h:1744:3: note: declared here
 1744 |   Call(int argc, v8::Local<v8::Value> argv[]) const {
      |   ^~~~
../src/binding.cc: In function ‘void nodeogg::Initialize(Nan::ADDON_REGISTER_FUNCTION_ARGS_TYPE)’:
../src/binding.cc:404:8: warning: ‘Nan::Maybe<bool> Nan::ForceSet(v8::Local<v8::Object>, v8::Local<v8::Value>, v8::Local<v8::Value>, v8::PropertyAttribute)’ is deprecated [-Wdeprecated-declarations]
  404 |   Nan::ForceSet(target, Nan::New<String>("sizeof_" #value).ToLocalChecked(), \
      |        ^~~~~~~~
../src/binding.cc:407:3: note: in expansion of macro ‘SIZEOF’
  407 |   SIZEOF(ogg_sync_state);
      |   ^~~~~~
In file included from ../../nan/nan.h:286,
                 from ../src/binding.cc:23:
../../nan/nan_maybe_43_inl.h:117:35: note: declared here
  117 | NAN_DEPRECATED inline Maybe<bool> ForceSet(
      |                                   ^~~~~~~~
../src/binding.cc:406:58: warning: ‘Nan::Maybe<bool> Nan::ForceSet(v8::Local<v8::Object>, v8::Local<v8::Value>, v8::Local<v8::Value>, v8::PropertyAttribute)’ is deprecated [-Wdeprecated-declarations]
  406 |       static_cast<PropertyAttribute>(ReadOnly|DontDelete))
      |                                                          ^
../src/binding.cc:407:3: note: in expansion of macro ‘SIZEOF’
  407 |   SIZEOF(ogg_sync_state);
      |   ^~~~~~
In file included from ../../nan/nan.h:286,
                 from ../src/binding.cc:23:
../../nan/nan_maybe_43_inl.h:117:35: note: declared here
  117 | NAN_DEPRECATED inline Maybe<bool> ForceSet(
      |                                   ^~~~~~~~
../src/binding.cc:406:58: warning: ‘Nan::Maybe<bool> Nan::ForceSet(v8::Local<v8::Object>, v8::Local<v8::Value>, v8::Local<v8::Value>, v8::PropertyAttribute)’ is deprecated [-Wdeprecated-declarations]
  406 |       static_cast<PropertyAttribute>(ReadOnly|DontDelete))
      |                                                          ^
../src/binding.cc:407:3: note: in expansion of macro ‘SIZEOF’
  407 |   SIZEOF(ogg_sync_state);
      |   ^~~~~~
In file included from ../../nan/nan.h:286,
                 from ../src/binding.cc:23:
../../nan/nan_maybe_43_inl.h:117:35: note: declared here
  117 | NAN_DEPRECATED inline Maybe<bool> ForceSet(
      |                                   ^~~~~~~~
../src/binding.cc:404:8: warning: ‘Nan::Maybe<bool> Nan::ForceSet(v8::Local<v8::Object>, v8::Local<v8::Value>, v8::Local<v8::Value>, v8::PropertyAttribute)’ is deprecated [-Wdeprecated-declarations]
  404 |   Nan::ForceSet(target, Nan::New<String>("sizeof_" #value).ToLocalChecked(), \
      |        ^~~~~~~~
../src/binding.cc:408:3: note: in expansion of macro ‘SIZEOF’
  408 |   SIZEOF(ogg_stream_state);
      |   ^~~~~~
In file included from ../../nan/nan.h:286,
                 from ../src/binding.cc:23:
../../nan/nan_maybe_43_inl.h:117:35: note: declared here
  117 | NAN_DEPRECATED inline Maybe<bool> ForceSet(
      |                                   ^~~~~~~~
../src/binding.cc:406:58: warning: ‘Nan::Maybe<bool> Nan::ForceSet(v8::Local<v8::Object>, v8::Local<v8::Value>, v8::Local<v8::Value>, v8::PropertyAttribute)’ is deprecated [-Wdeprecated-declarations]
  406 |       static_cast<PropertyAttribute>(ReadOnly|DontDelete))
      |                                                          ^
../src/binding.cc:408:3: note: in expansion of macro ‘SIZEOF’
  408 |   SIZEOF(ogg_stream_state);
      |   ^~~~~~
In file included from ../../nan/nan.h:286,
                 from ../src/binding.cc:23:
../../nan/nan_maybe_43_inl.h:117:35: note: declared here
  117 | NAN_DEPRECATED inline Maybe<bool> ForceSet(
      |                                   ^~~~~~~~
../src/binding.cc:406:58: warning: ‘Nan::Maybe<bool> Nan::ForceSet(v8::Local<v8::Object>, v8::Local<v8::Value>, v8::Local<v8::Value>, v8::PropertyAttribute)’ is deprecated [-Wdeprecated-declarations]
  406 |       static_cast<PropertyAttribute>(ReadOnly|DontDelete))
      |                                                          ^
../src/binding.cc:408:3: note: in expansion of macro ‘SIZEOF’
  408 |   SIZEOF(ogg_stream_state);
      |   ^~~~~~
In file included from ../../nan/nan.h:286,
                 from ../src/binding.cc:23:
../../nan/nan_maybe_43_inl.h:117:35: note: declared here
  117 | NAN_DEPRECATED inline Maybe<bool> ForceSet(
      |                                   ^~~~~~~~
../src/binding.cc:404:8: warning: ‘Nan::Maybe<bool> Nan::ForceSet(v8::Local<v8::Object>, v8::Local<v8::Value>, v8::Local<v8::Value>, v8::PropertyAttribute)’ is deprecated [-Wdeprecated-declarations]
  404 |   Nan::ForceSet(target, Nan::New<String>("sizeof_" #value).ToLocalChecked(), \
      |        ^~~~~~~~
../src/binding.cc:409:3: note: in expansion of macro ‘SIZEOF’
  409 |   SIZEOF(ogg_page);
      |   ^~~~~~
In file included from ../../nan/nan.h:286,
                 from ../src/binding.cc:23:
../../nan/nan_maybe_43_inl.h:117:35: note: declared here
  117 | NAN_DEPRECATED inline Maybe<bool> ForceSet(
      |                                   ^~~~~~~~
../src/binding.cc:406:58: warning: ‘Nan::Maybe<bool> Nan::ForceSet(v8::Local<v8::Object>, v8::Local<v8::Value>, v8::Local<v8::Value>, v8::PropertyAttribute)’ is deprecated [-Wdeprecated-declarations]
  406 |       static_cast<PropertyAttribute>(ReadOnly|DontDelete))
      |                                                          ^
../src/binding.cc:409:3: note: in expansion of macro ‘SIZEOF’
  409 |   SIZEOF(ogg_page);
      |   ^~~~~~
In file included from ../../nan/nan.h:286,
                 from ../src/binding.cc:23:
../../nan/nan_maybe_43_inl.h:117:35: note: declared here
  117 | NAN_DEPRECATED inline Maybe<bool> ForceSet(
      |                                   ^~~~~~~~
../src/binding.cc:406:58: warning: ‘Nan::Maybe<bool> Nan::ForceSet(v8::Local<v8::Object>, v8::Local<v8::Value>, v8::Local<v8::Value>, v8::PropertyAttribute)’ is deprecated [-Wdeprecated-declarations]
  406 |       static_cast<PropertyAttribute>(ReadOnly|DontDelete))
      |                                                          ^
../src/binding.cc:409:3: note: in expansion of macro ‘SIZEOF’
  409 |   SIZEOF(ogg_page);
      |   ^~~~~~
In file included from ../../nan/nan.h:286,
                 from ../src/binding.cc:23:
../../nan/nan_maybe_43_inl.h:117:35: note: declared here
  117 | NAN_DEPRECATED inline Maybe<bool> ForceSet(
      |                                   ^~~~~~~~
../src/binding.cc:404:8: warning: ‘Nan::Maybe<bool> Nan::ForceSet(v8::Local<v8::Object>, v8::Local<v8::Value>, v8::Local<v8::Value>, v8::PropertyAttribute)’ is deprecated [-Wdeprecated-declarations]
  404 |   Nan::ForceSet(target, Nan::New<String>("sizeof_" #value).ToLocalChecked(), \
      |        ^~~~~~~~
../src/binding.cc:410:3: note: in expansion of macro ‘SIZEOF’
  410 |   SIZEOF(ogg_packet);
      |   ^~~~~~
In file included from ../../nan/nan.h:286,
                 from ../src/binding.cc:23:
../../nan/nan_maybe_43_inl.h:117:35: note: declared here
  117 | NAN_DEPRECATED inline Maybe<bool> ForceSet(
      |                                   ^~~~~~~~
../src/binding.cc:406:58: warning: ‘Nan::Maybe<bool> Nan::ForceSet(v8::Local<v8::Object>, v8::Local<v8::Value>, v8::Local<v8::Value>, v8::PropertyAttribute)’ is deprecated [-Wdeprecated-declarations]
  406 |       static_cast<PropertyAttribute>(ReadOnly|DontDelete))
      |                                                          ^
../src/binding.cc:410:3: note: in expansion of macro ‘SIZEOF’
  410 |   SIZEOF(ogg_packet);
      |   ^~~~~~
In file included from ../../nan/nan.h:286,
                 from ../src/binding.cc:23:
../../nan/nan_maybe_43_inl.h:117:35: note: declared here
  117 | NAN_DEPRECATED inline Maybe<bool> ForceSet(
      |                                   ^~~~~~~~
../src/binding.cc:406:58: warning: ‘Nan::Maybe<bool> Nan::ForceSet(v8::Local<v8::Object>, v8::Local<v8::Value>, v8::Local<v8::Value>, v8::PropertyAttribute)’ is deprecated [-Wdeprecated-declarations]
  406 |       static_cast<PropertyAttribute>(ReadOnly|DontDelete))
      |                                                          ^
../src/binding.cc:410:3: note: in expansion of macro ‘SIZEOF’
  410 |   SIZEOF(ogg_packet);
      |   ^~~~~~
In file included from ../../nan/nan.h:286,
                 from ../src/binding.cc:23:
../../nan/nan_maybe_43_inl.h:117:35: note: declared here
  117 | NAN_DEPRECATED inline Maybe<bool> ForceSet(
      |                                   ^~~~~~~~
../src/binding.cc:434:77: error: no matching function for call to ‘v8::FunctionTemplate::GetFunction()’
  434 |     Nan::New<FunctionTemplate>(node_ogg_packet_replace_buffer)->GetFunction());
      |                                                                             ^
In file included from /home/george/.cache/node-gyp/16.13.0/include/node/node.h:63,
                 from ../src/binding.cc:22:
/home/george/.cache/node-gyp/16.13.0/include/node/v8.h:6802:46: note: candidate: ‘v8::MaybeLocal<v8::Function> v8::FunctionTemplate::GetFunction(v8::Local<v8::Context>)’
 6802 |   V8_WARN_UNUSED_RESULT MaybeLocal<Function> GetFunction(
      |                                              ^~~~~~~~~~~
/home/george/.cache/node-gyp/16.13.0/include/node/v8.h:6802:46: note:   candidate expects 1 argument, 0 provided
In file included from ../src/binding.cc:22:
../src/binding.cc: At global scope:
/home/george/.cache/node-gyp/16.13.0/include/node/node.h:821:43: warning: cast between incompatible function types from ‘void (*)(Nan::ADDON_REGISTER_FUNCTION_ARGS_TYPE)’ {aka ‘void (*)(v8::Local<v8::Object>)’} to ‘node::addon_register_func’ {aka ‘void (*)(v8::Local<v8::Object>, v8::Local<v8::Value>, void*)’} [-Wcast-function-type]
  821 |       (node::addon_register_func) (regfunc),                          \
      |                                           ^
/home/george/.cache/node-gyp/16.13.0/include/node/node.h:855:3: note: in expansion of macro ‘NODE_MODULE_X’
  855 |   NODE_MODULE_X(modname, regfunc, NULL, 0)  // NOLINT (readability/null_usage)
      |   ^~~~~~~~~~~~~
../src/binding.cc:440:1: note: in expansion of macro ‘NODE_MODULE’
  440 | NODE_MODULE(ogg, nodeogg::Initialize)
      | ^~~~~~~~~~~
make: *** [ogg.target.mk:120: Release/obj.target/ogg/src/binding.o] Error 1
make: Leaving directory '/home/george/js/vocall/node_modules/ogg/build'
gyp ERR! build error 
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/home/george/.nvm/versions/node/v16.13.0/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:194:23)
gyp ERR! stack     at ChildProcess.emit (node:events:390:28)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (node:internal/child_process:290:12)
gyp ERR! System Linux 5.13.0-28-generic
gyp ERR! command "/home/george/.nvm/versions/node/v16.13.0/bin/node" "/home/george/.nvm/versions/node/v16.13.0/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /home/george/js/vocall/node_modules/ogg
gyp ERR! node -v v16.13.0
gyp ERR! node-gyp -v v8.2.0
gyp ERR! not ok
info Visit https://yarnpkg.com/en/docs/cli/add for documentation about this command.