added host as servername to tls connection options, if servername is …

TooTallNate / node-pac-proxy-agent

A PAC file proxy `http.Agent` implementation for HTTP and HTTPS

59 stars 57 forks source link

added host as servername to tls connection options, if servername is … #19

Closed idobh2 closed 1 year ago

idobh2 commented 6 years ago

I had an issue getting an ssl handshake failure error using a PAC based proxy configuration. Turns out servername must be provided to tls.connect(). I saw you had had it in your other "...-proxy-agent" so I just added the same here

TooTallNate commented 1 year ago

This code in this repository has been moved to the proxy-agents monorepo, so I am closing this pull request. If you feel that this change is still necessary as of the latest release, feel free to open a new pull request over there.