Fix for proxy not accessible

TooTallNate / node-pac-proxy-agent

A PAC file proxy `http.Agent` implementation for HTTP and HTTPS

59 stars 57 forks source link

Fix for proxy not accessible #35

Closed kimihiro64 closed 1 year ago

kimihiro64 commented 4 years ago

Handle error when resolver is not able to be loaded and fall back to direct, addresses #34

kimihiro64 commented 4 years ago

I think something similar needs to be done for addressing the same error in proxy-agent, but it looks like each individual proxy agent actually needs to be fixed (http-proxy-agent, https-proxy-agent, socks-proxy-agent)... I'm not 100% sure how to apply those fixes right now

TooTallNate commented 1 year ago

This code in this repository has been moved to the proxy-agents monorepo, so I am closing this pull request. If you feel that this change is still necessary as of the latest release, feel free to open a new pull request over there.