search

TooTallNate / node-proxy-agent

Maps proxy protocols to `http.Agent` implementations
285 stars 69 forks source link

Release 2.3.0 is broken on node@4.x #18

Closed ggoodman closed 6 years ago

ggoodman commented 6 years ago

@TooTallNate this change results in the new socks-proxy-agent@4 being pulled in. The 4.x series of socks-proxy-agent introduces a node>=6 constraint due to its reliance on socks@2 (and probably other things) where newer syntax (function argument defaults) is introduced that is a syntax error on node@4.x.

Would you consider releasing this as a new major considering this backwards incompatibility and re-releasing a 2.3.x patch release reverting the socks-proxy-agent bump?

How can I help expedite this?

ggoodman commented 6 years ago

Please also see: https://travis-ci.org/TooTallNate/node-proxy-agent/builds/365266572

liuzhen2008 commented 6 years ago

Please revert this change or at least mark the version to be 3.0.0

My production servers are breaking right now because of this.

This is a breaking change and should not be included in a minor version bump!

TooTallNate commented 6 years ago

Damn, nice catch :(

@ggoodman Can I give you push access to these -proxy-agent repos?

ggoodman commented 6 years ago

Hi @TooTallNate, if you're ok with that and you find yourself in a bandwidth crunch, let's do it. Is there a way I can reach you when PRs are ready to merge / publish?

I won't be able to deal with this until tomorrow morning (EDT).

TooTallNate commented 6 years ago

@ggoodman Ok added. Twitter DM should work, or ping me on https://zeit.chat