search

TooTallNate / node-proxy-agent

Maps proxy protocols to `http.Agent` implementations
285 stars 69 forks source link

Create new release with socks-proxy updated #27

Closed txusinho closed 3 years ago

txusinho commented 6 years ago

Dear @TooTallNate,

According to the last tag of this package(3.0.0 on https://github.com/TooTallNate/node-proxy-agent/commit/65fcf7af73fb1324c7e29ff7dee63b962951b457), the socks-proxy-agent is set to 3.0.0 (https://github.com/TooTallNate/node-proxy-agent/blob/65fcf7af73fb1324c7e29ff7dee63b962951b457/package.json#L39).

Current master branch is updated (https://github.com/TooTallNate/node-proxy-agent/commit/d67cb23de2a7e0b98d0d0619086fd475c7a47d44), but there's no way to fetch that fix with an exact version of the package.

I kindly ask you to tag a new version in this repo, so that I can send another PR to the people of nightwatch to fix the following vulnerability:


socks@1.1.10: If using 2.x branch, please upgrade to at least 2.1.6 to avoid a serious bug with socket data flow and an import issue introduced in 2.1.0

Thank you for your time reading this issue

SkyHacks commented 6 years ago

@TooTallNate This issue is also blocking a PR I'm creating for superagent-proxy to remove the socks deprecation warning.

xzyfer commented 5 years ago

Is this resolved now that #30 has been merged?