This change is to have node-proxy-agent honor the no_proxy environment variable.
This sets the protocol attribute on the object that is passed to proxy-from-env. If the protocol attribute is not there getProxyFromEnv pretty much just returns immediately. Setting this gets everything to work nicely.
Overall problem:
We are using serverless framework here, which in turn uses node-https-proxy-agent. Which does not use the no_proxy environment variables. This causes us an issue as S3 buckets with VPC endpoints are accessed with no_proxy so we can't deploy using buckets with private endpoints, unless the no_proxy environment variables are used..
We have moved serverless to use node-proxy-agent over node-https-proxy-agent with this internally, and intend to raise a request vs serverless with this change once this the arguments that go to proxy-from-env have the protocol in them.
Hey,
This change is to have node-proxy-agent honor the no_proxy environment variable.
This sets the protocol attribute on the object that is passed to proxy-from-env. If the protocol attribute is not there getProxyFromEnv pretty much just returns immediately. Setting this gets everything to work nicely.
Overall problem: We are using serverless framework here, which in turn uses node-https-proxy-agent. Which does not use the no_proxy environment variables. This causes us an issue as S3 buckets with VPC endpoints are accessed with no_proxy so we can't deploy using buckets with private endpoints, unless the no_proxy environment variables are used..
We have moved serverless to use node-proxy-agent over node-https-proxy-agent with this internally, and intend to raise a request vs serverless with this change once this the arguments that go to proxy-from-env have the protocol in them.