Update request agent-base

TooTallNate / node-proxy-agent

Maps proxy protocols to `http.Agent` implementations

285 stars 69 forks source link

Update request agent-base #51

Closed seiya-git closed 4 years ago

seiya-git commented 4 years ago

Please update agent-base dependency in package.json ref: TooTallNate/node-agent-base#35

seiya-git commented 4 years ago

@TooTallNate ping?

JasonZigelbaum commented 4 years ago

@TooTallNate is it possible to get an update on this? It's causing issues for anyone using this package (or a package using this package) with the same severity as: https://github.com/TooTallNate/node-agent-base/issues/35. Thanks!

ghost commented 4 years ago

We very much need this updated so we can get around TooTallNate/node-agent-base#35

artem-karpenko commented 4 years ago

Need this very much, in particular this makes got requests fail when node-proxy-agent is indirectly required. Any update, @TooTallNate?

magicdawn commented 4 years ago

ping @TooTallNate again, +1 on got proxy issues.

boisei0 commented 4 years ago

Additonally, when updating please release this as minor release rather than a major like happened with agent-base itself. Any attempts at using got in integrations in other projects that might have other integrations depending somewhere on any of the proxy-agents, makes it impossible to use https URLs because of the patching in v4 of agent-base. another ping for @TooTallNate

apexad commented 4 years ago

Need this too! Please @TooTallNate

vnenkpet commented 4 years ago

Google Cloud suddenly probably changed its nodejs10 runtime and this became an issue for us using got. I can't find a proper solution for this.

santiago-perez-axa commented 4 years ago

I also got the same problem with got versions >=10

vnenkpet commented 4 years ago

Just a tip for anyone who needs to solve this - try running npm ls agent-node and see which dependencies require the old version. For me it was the mailgun-js package so I fixed my problem by removing it and implementing Mailgun API client myself.

fishsaidno commented 4 years ago

└─┬ node-lambda@0.17.0
  └─┬ proxy-agent@3.1.1
    ├── agent-base@4.3.0           <---
    ├─┬ http-proxy-agent@2.1.0
    │ └── agent-base@4.3.0         <---
    ├─┬ https-proxy-agent@3.0.1
    │ └── agent-base@4.3.0         <---
    ├─┬ pac-proxy-agent@3.0.1
    │ └── agent-base@4.3.0         <---
    └─┬ socks-proxy-agent@4.0.2
      └── agent-base@4.2.1         <---

alvis commented 4 years ago

ping @TooTallNate Sorry to bother, but the outdated dependency on socks-proxy-agent is causing problems on us.