search

TooTallNate / node-speaker

Output PCM audio data to the speakers
648 stars 145 forks source link

Adding TS typings. #122

Closed Fazendaaa closed 5 years ago

Fazendaaa commented 5 years ago

Hey, @TooTallNate. Thanks for this awesome package!

Due to Hacktoberfest 2018, I'm contributing to some packages that I use; yours is one of those.

TypeScript typings help a lot of us who use it due to it's integration to TSLint and some more strict checkings, needed to be performed in some cases in the used packages as well; that's why I've decided to share the ones that I've made, making it more accessible to all that programs in this environment :)

Since I'm not altering any of your JavaScript code, didn't feel the need to write any test, and I only made typings for those methods flagged as public in your API JSDoc. But I ran the documentation examples in a dummy tests scenario through ts-node.

note: this is the project that I use your package, I intend to go back to it someday: https://github.com/Fazendaaa/ytlofi.

TooTallNate commented 5 years ago

Very cool! Thank you @Fazendaaa 👍

LinusU commented 5 years ago

Awesome work 👏

Left a few comments that would be nice to address in a follow up PR ☺️

LinusU commented 5 years ago

🚢 Released in 0.4.2