💥 Build using N-API instead of NAN

TooTallNate / node-speaker

Output PCM audio data to the speakers

648 stars 145 forks source link

Closed LinusU closed 4 years ago

LinusU commented 4 years ago

closes #133, fixes #134, fixes #131, fixes #114, fixes #106, fixes #83, fixes #81, fixes #78, fixes #59

TooTallNate commented 4 years ago

Wow this is awesome 😄

LinusU commented 4 years ago

Thanks for the review! I didn't know you were actively looking at this ☺️

Since I thought that I was probably going to be the only one to commit I started tagging my commits with emoji-commit since I planed on using emoji-github-releases to automatically generate the changelogs (some examples: ts-readme-generator/releases, vscode-auto-dark-mode/releases)

We can skip it if you want though!

Otherwise, I'll merge this when the CI is green and then release 0.5.0 :shipit:

LinusU commented 4 years ago

Rebased away some redundant commits, merging as soon as CI is green 🚀

LinusU commented 4 years ago

JonSilver commented 4 years ago

Still experiencing #131