search

TooTallNate / node-speaker

Output PCM audio data to the speakers
655 stars 147 forks source link

License listed as MIT, but some of the source lists LGPL #167

Closed daytonellwanger closed 3 years ago

daytonellwanger commented 3 years ago

The license for the package is listed as MIT. But some of the code, e.g. here, specifies the LGPL license. What's the correct license for this package?

LinusU commented 3 years ago

This node-speaker library code is licensed under MIT, and the dependency mpg123 is licensed under LGPL 2.1

daytonellwanger commented 3 years ago

Does that need to be documented in any way? Presumably anyone that uses this package is also bundling the mpg123 dependency. And I know that for me at least it wasn't clear that I was using LGPL 2.1 software, which could have ramifications for some uses.

LinusU commented 3 years ago

Does that need to be documented in any way?

I don't know 😅

Maybe like this: #168

daytonellwanger commented 3 years ago

Maybe? Honestly I'm not sure either.

LinusU commented 3 years ago

Merged that one ☺️