TooTallNate / node-speaker

Output PCM audio data to the speakers
648 stars 145 forks source link

Switch from deprecated Carbon Component API ... #86

Closed sparkpunkd closed 7 years ago

sparkpunkd commented 7 years ago

... to AudioUnit AudioComponent API.

Should work on SnowLeopard 10.6 onwards. Fixes issue #69

fritx commented 7 years ago

@sparkpunkd is this branch published on npm?

LinusU commented 7 years ago

Hi @sparkpunkd,

Sorry that this has gone unnoticed for such a long time. Do you think we should publish this a breaking version, or do we think that everyone already is on 10.6 and up and just push this as a patch release?

sparkpunkd commented 7 years ago

@fritx This pull request is not published to npm ... waiting on pull request acceptance.

@LinusU I'm no expert, but a Google search tells me that in 2014, less than 2% of Macs are on 10.6 or earlier, which would suggest a patch release? See https://www.intego.com/mac-security-blog/os-x-market-share-statistics-1-in-5-macs-still-unsupported/

LinusU commented 7 years ago

Awesome! Again, sorry for the delay...

LinusU commented 7 years ago

(btw, the failing AppVeyor build seemed unrelated...)

LinusU commented 7 years ago

Published as 0.3.1