TooTallNate / node-telnet

Telnet implementation for Node.js
87 stars 30 forks source link

Implement environment variable parsing. #13

Closed chjj closed 9 years ago

chjj commented 9 years ago

This seems to work in practice. Would be nice to have it in.

TooTallNate commented 9 years ago

JJ! Nice stuff man. We can probably remove line 104 now too.

chjj commented 9 years ago

Yeah, I'll do that.

I was considering also implementing termtype, but it's not working yet since most servers have to respond with IAC SB TERMINAL-TYPE SEND IAC SE after the IAC WILL TERMINAL-TYPE. Might have to refactor some things. https://github.com/chjj/node-telnet/commit/833c73223e96c4ca361c093e53f1a08bd5241ded

chjj commented 9 years ago

This is pretty crucial now that blessed can work well over telnet. I want to see someone make a blessed+telnet mmorpg or something.

TooTallNate commented 9 years ago

Wow that would be awesome

chjj commented 9 years ago

Removed line 104.

chjj commented 9 years ago

Awesome. Thanks.