search

TooTallNate / plist.js

Mac OS X Plist parser/builder for Node.js and browsers
MIT License
592 stars 123 forks source link

npm audit fix --force (solves 13 critical vulnerabilities) #125

Closed trufae closed 2 years ago

trufae commented 2 years ago

Current npm audit ONLY affect devDependencies. so it's imho safe to go!

mreinstein commented 2 years ago

I'd rather solve this by removing the in-browser tests https://github.com/TooTallNate/plist.js/issues/126

trufae commented 2 years ago

There should be ways to test this library in the browser in ghci, but i have never done that. i'll keep that one for you :) thanks for the prompt responses and merges! i'm going to remove my forks and use the main repository.

mreinstein commented 2 years ago

There should be ways to test this library in the browser in ghci,

The existing project is set up to use sauce labs, and it technically should still work. I just don't think this really matters much any more. node tests are sufficient imo.

mreinstein commented 2 years ago

thanks for the prompt responses and merges

my pleasure, thanks for crushing through these issues like a boss.