search

TooTallNate / plist.js

Mac OS X Plist parser/builder for Node.js and browsers
MIT License
592 stars 123 forks source link

Add BigInt support #97

Closed dnicolson closed 4 years ago

dnicolson commented 5 years ago

This pull request fixes https://github.com/TooTallNate/plist.js/issues/96.

For additional compatibility BigInteger.js is supported.

detj commented 4 years ago

@mreinstein Can we merge this?

mreinstein commented 4 years ago

The tests appear to be failing now. Please fix this, and add unit tests for the BigInt support, then I'm happy to merge.

dnicolson commented 4 years ago

Unit tests have been added and Node.js 10 has been added to Travis CI as BigInt support was added in version 10.4.0.

The build is still failing due to the broken Zuul tests though.

mreinstein commented 4 years ago

@TooTallNate it looks like the zuul credentials embedded in the project no longer work. can you update these please? they are causing all builds in travis to break, blocking merges. 🙏