search

TooTallNate / proxy-agents

Node.js HTTP Proxy Agents Monorepo
https://proxy-agents.n8.io
873 stars 228 forks source link

Add TLS version config #128

Closed bobrowadam closed 2 years ago

bobrowadam commented 2 years ago

This PR will allow passing a minimal TLS version to the proxy request configuration. The default version is "TLSv1" which is the lowest, it might be better to use a newer version but I didn't want to break anything.

TooTallNate commented 2 years ago

Thanks for the PR @bobrowadam, but I'm inclined to not override the default values that Node.js uses. You should still be able to apply this by passing the option in the options object when using https.request() though:

https.request({ agent, minVersion: 'TLSv1', ... })
bobrowadam commented 2 years ago

Thanks for the review @TooTallNate. I'll try your suggestion