TooTallNate / proxy-agents

Node.js HTTP Proxy Agents Monorepo
https://proxy-agents.n8.io
919 stars 239 forks source link

Add servername to tls options when connecting in DIRECT #159

Closed mceIdo closed 1 year ago

mceIdo commented 1 year ago

This a recreation of this PR from the original repo, with adjustments to match the implementation in other proxy agents. I had an issue getting an ssl handshake failure error using a PAC based proxy configuration. Turns out servername must be provided to tls.connect(). I saw you had had it in your other "...-proxy-agent" so I just added the same here

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: 44a7b39da1b4087d45794f4762a1151181aa648a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | --------------- | ----- | | pac-proxy-agent | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
proxy-agents ✅ Ready (Inspect) Visit Preview May 7, 2023 10:24am
TooTallNate commented 1 year ago

Looks good. Thank you!