search

TooTallNate / proxy-agents

Node.js HTTP Proxy Agents Monorepo
https://proxy-agents.n8.io
872 stars 229 forks source link

Add support for mTLS #235

Open mg-dd opened 10 months ago

mg-dd commented 10 months ago

This PR fixes two issues:

https://github.com/TooTallNate/proxy-agents/issues/194 https://github.com/TooTallNate/proxy-agents/issues/234

The background is that the TLS connection established by the proxy agents do not add the required parameters for mTLS / self-signed CAs. This PR adds a way to provide these parameters. The general approach was taken from the feedback from this PR: https://github.com/TooTallNate/proxy-agents/pull/195/files

ptal @TooTallNate

changeset-bot[bot] commented 10 months ago

🦋 Changeset detected

Latest commit: 041a7c52dd9088a58aff8e84a79451c167c0d4a7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages | Name | Type | | ----------------- | ----- | | https-proxy-agent | Minor | | socks-proxy-agent | Minor | | agent-base | Minor |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 10 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
proxy-agents ✅ Ready (Inspect) Visit Preview Sep 4, 2023 9:13am
patrickheeney commented 10 months ago

@mg-dd Great PR! I need something similar, do you need any help pushing this over the finish line?

mg-dd commented 10 months ago

@TooTallNate this is ready for another look. The only open question is how you would like to handle the TLS connection in pac-proxy-agent.

brunobastosg commented 9 months ago

Hi, any news on this? I also need this feature.

amirbilu commented 8 months ago

Any news on this?

cptRaclette commented 8 months ago

@TooTallNate: Would love to see this feature in the proxy agents. Is there anything left to do?

orlando1108 commented 6 months ago

HI, any update about this PR ? 💯

marcchambon commented 5 months ago

Thank you soo much for maintaining this awesome project ! Any news ?

sibelius commented 5 months ago

can we move forward on this?

what is missing?

pebie commented 4 months ago

Thank you for this PR ! @TooTallNate Any news about moving forward ?

🙏 🙏

sibelius commented 2 months ago

we are using a patch of this pull request in production and it is working well

NasGldn commented 2 weeks ago

Hello, is there news about this ? We need it ! :) @TooTallNate