Use non-compliant URL from 'url' for socks urls

[indutny-signal]

new URL('socks://host:port') gives different results in browser and Node.js because socks is not among the "special schemes" specified by WHATWG and thus the hostname is treated as an opaque value (without parsing the port). Node.js implementation, however, parses the port.

Since proxy-agent can be used in Electron, unless URL is imported directly from the Node's url module - it is going to use the Browser's version of it which won't work with socks urls.

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
proxy-agents	✅ Ready (Inspect)	Visit Preview	Aug 29, 2023 7:14pm

[changeset-bot[bot]]

🦋 Changeset detected

Latest commit: d51474a99bdf0a333404c7a185aa8d7d2746be61

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

| Name | Type | | ----------------- | ----- | | socks-proxy-agent | Patch | | pac-proxy-agent | Patch | | proxy-agent | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[TooTallNate]

Makes sense. Thank you!

[indutny-signal]

Yay, thanks for merging this!

[lukekarrys]

It might be helpful to use a lint rule for this as well to keep it from possibly regressing.

I think no-restricted-globals should do the trick:

{
    "rules": {
        "no-restricted-globals": ["error", { "name": "URL", "message": "Use url.URL instead" }]
    }
}

[TooTallNate]

@lukekarrys would be happy to accept a PR!

[lukekarrys]

would be happy to accept a PR!

Done 😄! #246