search

TooTallNate / proxy-agents

Node.js HTTP Proxy Agents Monorepo
https://proxy-agents.n8.io
871 stars 229 forks source link

Certificates with IP addresses does not work with this change #308

Closed javidh closed 2 months ago

javidh commented 2 months ago

With this change, if we have a certificate for an ip address, it will throw an error:

https://github.com/TooTallNate/proxy-agents/blob/010fdc304a18931d2a1da7767e71303e7ce05abd/packages/socks-proxy-agent/src/index.ts#L178

It's not clear to me why this has been added but in many scenarios (especially with k8s structure where certificates are for ip addresses), this will break.

TooTallNate commented 2 months ago

I actually don't really recall what that was for. I want to say it was related to the tests, or perhaps I just didn't think it was possible to generate a cert with an IP address. In any case, it seems like the tests pass with the check removed (see #312).

TooTallNate commented 2 months ago

FWIW, Node prints this warning when an IP address is used for servername:

(node:28639) [DEP0123] DeprecationWarning: Setting the TLS ServerName to an IP address is not permitted by RFC 6066. This will be ignored in a future version. (Use node --trace-deprecation ... to show where the warning was created)