TooTallNate / proxy-agents

Node.js HTTP Proxy Agents Monorepo
https://proxy-agents.n8.io
919 stars 239 forks source link

Update `debug` to v4.0.0 #82

Closed Krinkle closed 4 years ago

Krinkle commented 4 years ago

Based on https://github.com/visionmedia/debug/releases/, it looks like there have been no breaking changes between debug 3.x and debug 4.x, except implicitly in the Node engine it supports. It now requires Node 6 (or higher), and no longer supports Node 4.

It looks like this package already requires Node 6, so that should be fine. I've updated the engines property in a separate commit to reflect this.

I'm proposing ^4.0.0 instead of explicitly requiring the latest point version (currently 4.1.1) because there have been no security fixes in-between, and no new features that node-https-proxy-agent depends on.

By default, this will do the same either way and uses the latest. But, it has the benefit of allowing de-duplication in downstream user applications with other packages that might be using an older 4.x version.


Ref https://github.com/GoogleChrome/puppeteer/issues/5026.