TooTallNate / proxy-agents

Node.js HTTP Proxy Agents Monorepo
https://proxy-agents.n8.io
944 stars 243 forks source link

Add support for "timeout" #96

Closed ejoebstl closed 1 year ago

ejoebstl commented 4 years ago

This changes makes https-proxy-agent respect the timeout parameter, so #1 is fixed.

Otherwise, the agent waits for unresponsive servers forever.

This does not take care of giving a clear error message yet.

sm2017 commented 4 years ago

@TooTallNate @lpinca I need this feature please accept the PR

sm2017 commented 3 years ago

@TooTallNate Please reply

XBeg9 commented 3 years ago

ping

0-don commented 3 years ago

ping

tayler-king commented 3 years ago

@TooTallNate is there a reason you aren't replying to this PR?

restyler commented 3 years ago

@TooTallNate is there a reason you aren't replying to this PR?

this project just seems to be abandoned. I've used https://github.com/ihof/node-https-proxy-agent instead though it's not as convenient to use the fork

jasonwilliams commented 2 years ago

Hey @TooTallNate are you still maintaining this project?

In the meantime ended up using https://github.com/delvedor/hpagent instead which is more maintained and did the job.

sspread commented 2 years ago

@jasonwilliams Ran into the same requirement for timeout. Tried hpagent and my http proxy fails to connect for 'http' servers (403). This is not an issue with nate's library. @TooTallNate would be great to get this PR in.

TooTallNate commented 1 year ago

This module has gone through a large refactor and modernization. I am closing this pull request as a bit of house cleaning. If you feel that this change is still necessary as of the latest release, feel free to open a new pull request.