TooTallNate / ref

Turn Buffer instances into "pointers"
http://tootallnate.github.com/ref
451 stars 141 forks source link

Support Node v12.0.0 #114

Open lxe opened 5 years ago

ravi-meganathan commented 5 years ago

Any update on Node.js 12 Support?

aabuhijleh commented 5 years ago

Nan::To can be used

Nan::To<bool>(info[3]).FromJust();

instead of

info[3]->BooleanValue(v8::Isolate::GetCurrent()->GetCurrentContext()).ToChecked();

the latter is very ugly